Skip to content

Make build use spawnAndCheck - #467

Merged
kainino0x merged 1 commit into
webgpu:mainfrom
greggman:fix-build
Oct 21, 2024
Merged

kainino0x merged 1 commit into
webgpu:mainfrom
greggman:fix-build

Conversation

@greggman

@greggman greggman commented Oct 19, 2024 •

Copy link
Copy Markdown
Member

I think this is the reason I didn't notice it fail. The build was using just spawn and so when rollup failed it didn't pass the exit status back out to the action so the action thought the build succeeded.

I think this is the reason I didn't notice it fail.
The build was using just spawn and so when rollup failed it
didn't pass the exit status back out to the action so
the action though the build succeeded.
@greggman
greggman requested a review from kainino0x October 21, 2024 01:39
@kainino0x
kainino0x merged commit edb4f12 into webgpu:main Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants